Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing KeptnAppVersion/KeptnWorkloadVersion span when one of the lifecycle phases fails #3130

Closed
Tracked by #218
odubajDT opened this issue Feb 27, 2024 · 2 comments · Fixed by #3174
Closed
Tracked by #218
Assignees
Labels
bug Something isn't working enhancement New feature or request lifecycle-operator

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Feb 27, 2024

Description

In the current state, when one of the phases fails (it does not matter whether on KeptnApp or KeptnWorkload level) the KeptnAppVersion span is not ended properly (and missing completely), which leads to a wrong child/parent structure when reviewing the results in Jeager or Grafana. The same problem is present for KeptnWorkloadVersion span, when one of the KeptWorkload phases fail.

Failure on KeptnApp level

Screenshot 2024-02-27 at 12 59 02

Failure on KeptnWorkload level

Screenshot 2024-02-27 at 12 47 45

Expected behavior

The spans should be correctly formatted and the KeptnAppVersion/KeptnWorkloadVersion span should exist even if the deployment of the application fails.

@thisthat
Copy link
Member

it is unclear to me what do you mean by "correctly formatted". We do not have client/server types so there is no need for a child to finish before a parent.

@odubajDT
Copy link
Contributor Author

it is unclear to me what do you mean by "correctly formatted". We do not have client/server types so there is no need for a child to finish before a parent.

True, we can then format the problem that the KeptnAppVersion span is missing.

@odubajDT odubajDT changed the title Spans not correctly formatted when one of the lifecycle phases fails Missing KeptnAppVersion span when one of the lifecycle phases fails Feb 27, 2024
@odubajDT odubajDT changed the title Missing KeptnAppVersion span when one of the lifecycle phases fails Missing KeptnAppVersion/KeptnWorkloadVersion span when one of the lifecycle phases fails Feb 27, 2024
@odubajDT odubajDT added status: ready-for-refinement Issue is relevant for the next backlog refinment enhancement New feature or request and removed bug Something isn't working labels Feb 27, 2024
@mowies mowies added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request labels Mar 4, 2024
@mowies mowies removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lifecycle-operator
Projects
Archived in project
4 participants