feat(lifecycle-operator): adapt WorkloadVersionReconciler logic to use ObservabilityTimeout for workload deployment #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3160 +/- ##
===========================================
- Coverage 86.85% 53.43% -33.43%
===========================================
Files 162 22 -140
Lines 8605 1398 -7207
===========================================
- Hits 7474 747 -6727
+ Misses 841 555 -286
+ Partials 290 96 -194
... and 150 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
…e ObservabilityTimeout for workload deployment Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
bacherfl
reviewed
Mar 4, 2024
lifecycle-operator/apis/lifecycle/v1beta1/keptnworkloadversion_types.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Mar 4, 2024
lifecycle-operator/controllers/lifecycle/keptnworkloadversion/reconcile_deploymentstate.go
Outdated
Show resolved
Hide resolved
bacherfl
previously approved these changes
Mar 4, 2024
Signed-off-by: odubajDT <[email protected]>
bacherfl
approved these changes
Mar 4, 2024
|
RealAnna
approved these changes
Mar 4, 2024
This was referenced Mar 4, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
…e ObservabilityTimeout for workload deployment (keptn#3160) Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3134
Depends on #3163