Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): Copy annotations from parent resource if not defined on pod #305

Merged
merged 41 commits into from
Nov 14, 2022
Merged

feat(operator): Copy annotations from parent resource if not defined on pod #305

merged 41 commits into from
Nov 14, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 3, 2022

Fixes #67

@mowies mowies force-pushed the annotations-from-upper-level-resource branch from f07b63f to 9fc9a78 Compare November 3, 2022 14:38
@thschue thschue mentioned this pull request Nov 4, 2022
Closed
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022 •
edited by codecov bot
Loading

Codecov Report

Merging #305 (64bccea) into main (277be10) will increase coverage by 4.48%.
The diff coverage is 78.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   19.45%   23.94%   +4.48%     
==========================================
  Files          13       14       +1     
  Lines        1074     1466     +392     
==========================================
+ Hits          209      351     +142     
- Misses        850     1097     +247     
- Partials       15       18       +3
Impacted Files Coverage Δ
operator/webhooks/pod_mutating_webhook.go 36.22% <78.33%> (ø)
Flag Coverage Δ
keptn-lifecycle-operator 27.38% <78.33%> (+4.06%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies force-pushed the annotations-from-upper-level-resource branch 2 times, most recently from 335f343 to 9342df3 Compare November 9, 2022 10:30
@mowies mowies marked this pull request as ready for review November 9, 2022 11:55
@mowies mowies changed the title feat: Copy annotations from parent resource if not defined on pod feat(operator): Copy annotations from parent resource if not defined on pod Nov 9, 2022
RealAnna
RealAnna requested changes Nov 9, 2022
View reviewed changes
operator/webhooks/pod_mutating_webhook.go Outdated Show resolved Hide resolved
operator/webhooks/pod_mutating_webhook.go Show resolved Hide resolved
operator/webhooks/pod_mutating_webhook.go Show resolved Hide resolved
operator/webhooks/pod_mutating_webhook.go Outdated Show resolved Hide resolved
@mowies mowies marked this pull request as draft November 9, 2022 13:05
@mowies mowies force-pushed the annotations-from-upper-level-resource branch from ec1d71c to 92773fd Compare November 10, 2022 14:58
mowies added 14 commits November 14, 2022 10:20
@mowies @bacherfl
first implementation steps
3013925 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix typo in readme
c72f5d2 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
add label copying for dp, sts and ds
82867fa 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
go fmt
55b580a 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
remove duplicate methods in favor of generalized ones
2f0862c 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
remove unneeded length checks
058fca4 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
move code to separate function to reduce complexity
5c59ec8 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
rename to kltv1alpha1
7c8352b 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
small refactoring, adjust return values
35273a0 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
remove unneeded initialization
fe41484 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
initialize map correctly
3debb0c 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
add label copy for all pre/post deployment/evaluation labels
6022a74 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
add namespace to single service example
0d07b5c 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
add permission to list apps.v1 resources to operator
d32f6c9 
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies and others added 21 commits November 14, 2022 10:20
@mowies @bacherfl
check if pod reference got updated correctly
872d7cb 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
add error when parent rs of pod cannot be found
cb0166f 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
typo
75bc13d 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
more tests and added error if rs of pod doesnt have an owner
eea85a7 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix behaviour when no owner is found
8a95ee3 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
more tests, also copy over app name
37c3e48 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix rebase artifact
4a1b565 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
more tests
4ab3b21 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
optimise finding of owner a little bit
b4de62d 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix some refactoring things
6b19285 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
go fmt
9925ebb 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
update the whole process with switch case and change behaviour
2378248 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
simplify the whole thing by using get instead of list and search
ccf00c3 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
update CRDs accordingly
8881c94 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix unit tests
4504446 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
refactoring
33552ea 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
move error check as per review request
c8372e6 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
remove unneeded permissions
6c78d1b 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix typo
22f9c98 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies @bacherfl
fix unit tests
65736b8 
Signed-off-by: Moritz Wiesinger <[email protected]>
@bacherfl
minor cleanups
13e8e20 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the annotations-from-upper-level-resource branch from 5eca9da to 13e8e20 Compare November 14, 2022 09:21
@bacherfl
pr review
64bccea 
Signed-off-by: Florian Bacher <[email protected]>
@RealAnna RealAnna marked this pull request as ready for review November 14, 2022 09:26
RealAnna
RealAnna approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bacherfl bacherfl merged commit c21f015 into keptn:main Nov 14, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 14, 2022
Merged
@mowies mowies deleted the annotations-from-upper-level-resource branch November 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@thisthat thisthat thisthat left review comments

@bacherfl bacherfl bacherfl approved these changes

@thschue thschue Awaiting requested review from thschue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate Deployment/StatefulSet/Daemonset Annotations to the Pods
5 participants
@mowies @codecov-commenter @thisthat @bacherfl @RealAnna