Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate Deployment/StatefulSet/Daemonset Annotations to the Pods #67

Closed
thschue opened this issue Sep 30, 2022 · 0 comments · Fixed by #305
Closed

Propagate Deployment/StatefulSet/Daemonset Annotations to the Pods #67

thschue opened this issue Sep 30, 2022 · 0 comments · Fixed by #305
Assignees
@mowies
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
2.0.0

Comments

@thschue
Copy link
Contributor

thschue commented Sep 30, 2022

At the moment, Annotations for using the Lifecycle Controller have to be set on a Pod Level. As this could lead to problems, it should also be possible to set them on a higher level, e.g. on a Deployment or Stateful Set, and they should be used in the lifecycle controller.

Annotations on the Pod Level should "win" if both are set.
@thschue thschue added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2022
@thisthat thisthat added this to the 1.0.x milestone Nov 2, 2022
@mowies mowies self-assigned this Nov 3, 2022
@mowies mowies mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mowies mowies

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
2.0.0
3 participants
@thisthat @mowies @thschue