Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add multiple metrics field descriptions to KeptnMetric CRD ref #2964

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

StackScribe
Copy link
Contributor

This PR provides some basic information about the multiple metrics feature to the KeptnMetric CRD ref page.

The software was implemented in #2190 .

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Feb 6, 2024
@StackScribe StackScribe added this to the 0.10 milestone Feb 6, 2024
@StackScribe StackScribe self-assigned this Feb 6, 2024
@StackScribe StackScribe requested review from a team as code owners February 6, 2024 12:18
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Copy link
Member

@rakshitgondwal rakshitgondwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-07 021457
The formating for query also seems to be off, maybe we can fix it in this PR itself.

StackScribe and others added 2 commits February 6, 2024 16:12
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@StackScribe StackScribe merged commit edb188d into main Feb 7, 2024
10 checks passed
@StackScribe StackScribe deleted the 0206-mult-metrics-ref branch February 7, 2024 10:21
Bharadwajshivam28 pushed a commit to Bharadwajshivam28/lifecycle-toolkit that referenced this pull request Feb 20, 2024
…eptn#2964)

Signed-off-by: Meg McRoberts <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]>
Signed-off-by: shivam <[email protected]>
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…eptn#2964)

Signed-off-by: Meg McRoberts <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants