Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Refactor Task, Evaluation handling + adapt span attributes setting #287

Merged
merged 29 commits into from
Nov 14, 2022
Merged

feat(operator): Refactor Task, Evaluation handling + adapt span attributes setting #287

merged 29 commits into from
Nov 14, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 2, 2022

Fixes: #376

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT changed the title feat(operator): Refactor Rask creation and reconciling feat(operator): Refactor Task, Evaluation handling + adapt span attributes setting Nov 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #287 (0a95d74) into main (d2c91d3) will increase coverage by 1.43%.
The diff coverage is 13.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   19.45%   20.89%   +1.43%     
==========================================
  Files          13       15       +2     
  Lines        1074     1096      +22     
==========================================
+ Hits          209      229      +20     
- Misses        850      852       +2     
  Partials       15       15              
Impacted Files Coverage Δ
operator/controllers/common/evaluationhandler.go 0.00% <0.00%> (ø)
operator/controllers/common/taskhandler.go 0.00% <0.00%> (ø)
...or/controllers/keptnworkloadinstance/controller.go 0.00% <0.00%> (ø)
...ptnworkloadinstance/reconcile_prepostdeployment.go 0.00% <0.00%> (ø)
...ptnworkloadinstance/reconcile_prepostevaluation.go 0.00% <0.00%> (ø)
operator/controllers/common/interfaces.go 100.00% <100.00%> (+20.00%) ⬆️
operator/controllers/common/spanhandler.go 67.85% <100.00%> (-3.12%) ⬇️
operator/controllers/keptnapp/controller.go 65.88% <100.00%> (-3.91%) ⬇️
Flag Coverage Δ
keptn-lifecycle-operator 25.02% <13.66%> (+1.69%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review November 14, 2022 07:35
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT merged commit 4d16a77 into keptn:main Nov 14, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spans have a wrong name
5 participants