Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spans have a wrong name #376

Closed
Tracked by #398
, #388
...
thisthat opened this issue Nov 10, 2022 · 2 comments · Fixed by #287
Closed
Tracked by #398
, #388
...

Spans have a wrong name #376

thisthat opened this issue Nov 10, 2022 · 2 comments · Fixed by #287
Assignees
@odubajDT
Labels
bug Something isn't working
Milestone
0.4.1

Comments

@thisthat
Copy link
Member

Problem

Span names have $workloadName/AppPostDeployEvaluation. This is wrong since a workload level cannot run app level steps.

Desired result: Span names have $workloadName/WorkloadPostDeployEvaluation.

Replication steps

Screenshot 2022-11-10 at 11 53 44
@thisthat thisthat added the bug Something isn't working label Nov 10, 2022
@thisthat thisthat added this to the 0.5.x milestone Nov 10, 2022
@thschue thschue modified the milestones: 0.5.x, 0.4.1 Nov 11, 2022
@thschue
Copy link
Contributor

thschue commented Nov 11, 2022

This might be part of #388

@thschue thschue changed the title Span have a wrong name Spans have a wrong name Nov 12, 2022
@thisthat thisthat moved this to 🎟️ Refined in Keptn Lifecycle Toolkit Nov 14, 2022
@odubajDT
Copy link
Contributor

I might think this was fixed as part of 4d16a77#diff-69e41fd278765f69df7af4225204fed47838a9fc5551532f4a1fa9b477aa1cd7L184

Currently with the build from latest master I can see right span names in the dashboard. @thisthat can you please confirm ?

@odubajDT odubajDT mentioned this issue Nov 15, 2022
Merged
Repository owner moved this from 🎟️ Refined to ✅ Done in Keptn Lifecycle Toolkit Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
bug Something isn't working
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

feat(operator): Refactor Task, Evaluation handling + adapt span attributes setting
3 participants
@thisthat @thschue @odubajDT