Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename Keptn default namespace to 'keptn-system' #2565

Merged
merged 4 commits into from
Nov 27, 2023
Merged

chore: rename Keptn default namespace to 'keptn-system' #2565

merged 4 commits into from
Nov 27, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 24, 2023

Fixes #2079

Depends on #2564

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit b41fa9f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65644af86b49fa0008477695
😎 Deploy Preview https://deploy-preview-2565--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #2565 (08cfac3) into main (9ee4583) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
+ Coverage   85.44%   85.51%   +0.06%     
==========================================
  Files         155      155              
  Lines       10178    10178              
==========================================
+ Hits         8697     8704       +7     
+ Misses       1201     1196       -5     
+ Partials      280      278       -2     
Files Coverage Δ
...okcontroller/keptnwebhookcertificate_controller.go 53.89% <ø> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 57.12% <ø> (-0.35%) ⬇️
lifecycle-operator 84.45% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@odubajDT odubajDT marked this pull request as ready for review November 27, 2023 08:53
@odubajDT odubajDT requested review from a team as code owners November 27, 2023 08:53
README.md Show resolved Hide resolved
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this huge renaming effort 🙌

Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving doc changes. Not qualified to approve the rest

@odubajDT odubajDT merged commit aec1148 into keptn:main Nov 27, 2023
48 checks passed
@StackScribe
Copy link
Contributor

Yes, serious thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename KLT code instances to Keptn
3 participants