Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: analysis feature in 0.9.0 #2424

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

StackScribe
Copy link
Contributor

Summary

  • Updates note that the Analysis feature is also preliminary on Analysis ref page to include 0.9.0
  • Expand information on the Analysis ref page about activating a preview of this feature
  • Make the AnalysisDefinition and AnalysisValueTemplate ref pages link to the Analysis ref page for implementation details rather than duplicating the information on each page

Note that the info about activating this feature that is on the "Install" page will also be modified to point to the Analysis ref page but I'll do that in #2419 which currently has that page open.

Checks

  • [n/a] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • n/a ] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Nov 6, 2023
@StackScribe StackScribe added this to the 0.10 milestone Nov 6, 2023
@StackScribe StackScribe self-assigned this Nov 6, 2023
@StackScribe StackScribe requested review from a team as code owners November 6, 2023 13:17
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 9ea6b41
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/654a0ce51152e80008c976cc
😎 Deploy Preview https://deploy-preview-2424--keptn-lifecycle-toolkit.netlify.app/docs/implementing/slo
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

StackScribe and others added 3 commits November 6, 2023 05:38
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
StackScribe and others added 2 commits November 6, 2023 13:01
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@StackScribe StackScribe requested a review from bacherfl November 7, 2023 10:14
@odubajDT odubajDT merged commit a6e6a60 into keptn:main Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants