Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify app autodiscovery annotation to app.kubernetes.io/managed-by: "keptn" #2211

Closed
5 tasks done
RealAnna opened this issue Oct 2, 2023 · 0 comments · Fixed by #2229
Closed
5 tasks done

Modify app autodiscovery annotation to app.kubernetes.io/managed-by: "keptn" #2211

RealAnna opened this issue Oct 2, 2023 · 0 comments · Fixed by #2229
Assignees
Milestone

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Oct 2, 2023

In Keptn Automatic App Discovery, we have a sample KeptnApp resource that includes the following:

apiVersion: lifecycle.keptn.sh/v1alpha2
kind: KeptnApp
metadata:
  name: podtato-head
  namespace: podtato-kubectl
  annotations:
    app.kubernetes.io/managed-by: "klt"

This is because the app discovery controller hardcodes a klt annotation if the app is autogenerated. This needs to change to "keptn" but we also need to keep for a while compatibility with old CR using "klt".

AC

  • Add an other annotion value set as 'keptn'
  • Make sure that both annotations are checked in the create function
  • When saving a new app CR only use the new annotation app.kubernetes.io/managed-by: "keptn"
  • When updating an app cr that has the old annotation replace it with app.kubernetes.io/managed-by: "keptn"
  • there is a separate issue to update all documentation files: remove user-visible klt strings from helm chart #2015
@RealAnna RealAnna changed the title Add a new annotation at app automatic creation that uses app.kubernetes.io/managed-by: "keptn" Modify app autodiscovery annotation to app.kubernetes.io/managed-by: "keptn" Oct 2, 2023
@RealAnna RealAnna added lifecycle-operator status: ready-for-refinement Issue is relevant for the next backlog refinment labels Oct 2, 2023
@mowies mowies added this to the 0.9 milestone Oct 2, 2023
@thisthat thisthat moved this to 🎟️ Refined in Keptn Lifecycle Toolkit Oct 4, 2023
@thisthat thisthat removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Oct 4, 2023
@RealAnna RealAnna self-assigned this Oct 4, 2023
@github-project-automation github-project-automation bot moved this from 🎟️ Refined to ✅ Done in Keptn Lifecycle Toolkit Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants