remove user-visible klt strings from helm chart

[StackScribe]

Need to scrub the Helm Chart for klt strings that are user-visible as part of the 7 Sept 2023 product name change.

For example, in Use Keptn Automatic App Discovery, we have a sample KeptnApp resource that includes the following:

apiVersion: lifecycle.keptn.sh/v1alpha2
kind: KeptnApp
metadata:
  name: podtato-head
  namespace: podtato-kubectl
  annotations:
    app.kubernetes.io/managed-by: "klt"

After this is fixed, update the aforementioned doc page.

AC

• update all documentation files

Depends on

• Modify app autodiscovery annotation to app.kubernetes.io/managed-by: "keptn" #2211

[agardnerIT]

This is not just a Helm change. That annotation is core to the functionality of KLT / Keptn.

Changing only this in the Helm chart will cause the deployments to fail.

There are checks all over the KeptnAppCreationRequest controller than not only check for, but actively create resources with this name.

https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/controllers/lifecycle/keptnappcreationrequest/controller.go#L103

lifecycle-toolkit/lifecycle-operator/controllers/lifecycle/keptnappcreationrequest/controller.go

Line 239 in 17ef13a

func (r *KeptnAppCreationRequestReconciler) createKeptnApp(ctx context.Context, creationRequest *lifecycle.KeptnAppCreationRequest, workloads []lifecycle.KeptnWorkload) error {

[RealAnna]

As @agardnerIT mentioned, we need to make sure that both the old klt annotation and the new keptn one are accepted in the logic at line103 so that we can have a smooth transition between the two installations.