feat(lifecycle-operator): add helm chart for lifecycle operator #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
+ Coverage 84.55% 84.63% +0.08%
==========================================
Files 154 154
Lines 9918 9957 +39
==========================================
+ Hits 8386 8427 +41
+ Misses 1246 1244 -2
Partials 286 286 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
reviewed
Sep 29, 2023
odubajDT
force-pushed
the
feat/lifecycle-operator-helm
branch
from
ce3d67f to
f1d9437
Compare
RealAnna
reviewed
Sep 29, 2023
RealAnna
reviewed
Sep 29, 2023
RealAnna
reviewed
Sep 29, 2023
RealAnna
reviewed
Sep 29, 2023
|
let's make sure automated app discovery keeeps on working like mentioned here |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
feat/lifecycle-operator-helm
branch
from
f1d9437 to
06e36e1
Compare
Signed-off-by: odubajDT <[email protected]>
According to tests, it should be working |
the chart is still called klt, I would prefer to call it lifecycle-operator or similar... and klt is what is than hardcoded in the label... but for that I would think to file a bug issue |
StackScribe
reviewed
Oct 2, 2023
StackScribe
reviewed
Oct 2, 2023
Signed-off-by: realanna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: RealAnna <[email protected]>
RealAnna
previously approved these changes
Oct 2, 2023
Signed-off-by: realanna <[email protected]>
RealAnna
previously approved these changes
Oct 2, 2023
mowies
reviewed
Oct 2, 2023
lifecycle-operator/chart/templates/lifecycle-manager-config.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mowies
approved these changes
Oct 2, 2023
RealAnna
approved these changes
Oct 2, 2023
This was referenced Oct 2, 2023
StackScribe
added a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Oct 13, 2023
…n#2200) Signed-off-by: odubajDT <[email protected]> Signed-off-by: realanna <[email protected]> Signed-off-by: RealAnna <[email protected]> Co-authored-by: realanna <[email protected]> Co-authored-by: RealAnna <[email protected]> Co-authored-by: Meg McRoberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2185
Follow up task: #2201