Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): introduce metric showing readiness of operator #2152

Conversation

geoffrey1330
Copy link
Member

fixes #1836

Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fd8436c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650d67f3cb4a8a0008689829
😎 Deploy Preview https://deploy-preview-2152--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2152 (f056a95) into main (6566e7d) will increase coverage by 0.09%.
Report is 43 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
+ Coverage   84.51%   84.61%   +0.09%     
==========================================
  Files         151      154       +3     
  Lines        9728     9957     +229     
==========================================
+ Hits         8222     8425     +203     
- Misses       1220     1245      +25     
- Partials      286      287       +1     

see 18 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.44% <ø> (+0.10%) ⬆️
lifecycle-operator 85.02% <ø> (+<0.01%) ⬆️
metrics-operator 87.55% <ø> (+0.15%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@geoffrey1330 geoffrey1330 changed the title Feat/1836/prepopulate keptn metrics lifecycle operator feat: add lifecycle_operator prepopulated keptn_ metrics to localhost:2222/metrics endpoint Sep 22, 2023
lifecycle-operator/main.go Show resolved Hide resolved
lifecycle-operator/main.go Outdated Show resolved Hide resolved
@mowies mowies changed the title feat: add lifecycle_operator prepopulated keptn_ metrics to localhost:2222/metrics endpoint feat: add lifecycle_operator prepopulated keptn_ metrics to metrics endpoint Sep 27, 2023
@RealAnna RealAnna requested a review from thisthat September 27, 2023 13:16
@odubajDT odubajDT changed the title feat: add lifecycle_operator prepopulated keptn_ metrics to metrics endpoint feat(lifecycle-operator): introduce metric showing readiness of operator Sep 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT
Copy link
Contributor

odubajDT commented Oct 3, 2023

@geoffrey1330 thank you for your contribution! :)

@odubajDT odubajDT merged commit c0e3f48 into keptn:main Oct 3, 2023
37 checks passed
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localhost:2222/metrics prepopulate with some keptn_ metrics
4 participants