Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localhost:2222/metrics prepopulate with some keptn_ metrics #1836

Closed
5 tasks
agardnerIT opened this issue Aug 4, 2023 · 4 comments · Fixed by #2152
Closed
5 tasks

localhost:2222/metrics prepopulate with some keptn_ metrics #1836

agardnerIT opened this issue Aug 4, 2023 · 4 comments · Fixed by #2152
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers update-requested

Comments

@agardnerIT
Copy link
Contributor

agardnerIT commented Aug 4, 2023

During initial installation, users can port forward to localhost:2222/metrics and see the Prometheus metrics page.

However, this page only shows the "default" go_ metrics (before a KeptnApp deployment has occurred.

This causes user confusion: Am I looking at the correct thing? Is Keptn working properly?

My suggestion would be to add a new metric with the prefix keptn_ which signals that KLT is indeed installed correctly and waiting.

Docs can always make this clear that new and additional metrics will flow in after the first deployment.

TLDR: Add a new keptn_active=1 (or equivalent) metric which appears OOTB before any application deployments.

DoD

  • have a new metric called keptn_lifecycle_active in the lifecycle-operator that is set to 1 as soon as the operator starts
  • have a new metric called keptn_metric_active in the metrics-operator that is set to 1 as soon as the operator starts
  • make a kuttl test with a job that checks the localhost:2222/metrics endpoint has the new metrics, you can take an example from this test

AC

  • integration tests are green
  • the example exercise shows the metrics on localhost:2222/metrics
@RealAnna RealAnna added the enhancement New feature or request label Aug 4, 2023
@thisthat thisthat added the good first issue Good for newcomers label Aug 8, 2023
@geoffrey1330
Copy link
Member

Hi @agardnerIT @RealAnna
could you please assign this issue to me.

@RealAnna
Copy link
Contributor

RealAnna commented Aug 8, 2023

thanks @geoffrey1330 I will assign you !

@github-actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@github-actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment