-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): Use Async Gauges for active KLC Entities #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
force-pushed
the
feat/gauge-metrics
branch
from
October 20, 2022 12:42
534157e
to
1c43c29
Compare
Signed-off-by: Florian Bacher <[email protected]>
RealAnna
reviewed
Oct 20, 2022
Signed-off-by: Florian Bacher <[email protected]>
RealAnna
previously approved these changes
Oct 20, 2022
Signed-off-by: Florian Bacher <[email protected]>
RealAnna
previously approved these changes
Oct 20, 2022
odubajDT
reviewed
Oct 20, 2022
Signed-off-by: Florian Bacher <[email protected]>
odubajDT
approved these changes
Oct 20, 2022
RealAnna
approved these changes
Oct 20, 2022
thschue
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mowies
pushed a commit
to mowies/lifecycle-controller
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Florian Bacher <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
pushed a commit
to mowies/lifecycle-controller
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Florian Bacher <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203
This makes sure that the number of active deployments/tasks/evaluations/apps stays consistent and there are not leftover counter values.
Example for active deployments in Grafana:
Signed-off-by: Florian Bacher [email protected]