Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metric for active application and workloads #203

Closed
1 task
thisthat opened this issue Oct 20, 2022 · 0 comments · Fixed by #206
Closed
1 task

Improve metric for active application and workloads #203

thisthat opened this issue Oct 20, 2022 · 0 comments · Fixed by #206
Assignees
Labels
enhancement New feature or request

Comments

@thisthat
Copy link
Member

Technical Details

The current implementation reports active deployments and apps via synchronous instruments with deltas.
This implementation has some drawbacks because items are removed from being active only when they have finished and an end time is set. If an external entity removes the CRDs, e.g., via kubectl delete, the value reported is out of sync with the real value.

Action item

Change the implementation to make use of async instrument via Gauges: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#asynchronous-gauge-creation

DoD

  • Metrics for active deployments are stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants