-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add info to implementing/tasks about sequential execution #1950
Conversation
Signed-off-by: Meg McRoberts <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording here confuses me.
To the question: "Can KeptnTasks be executed in sequential order", the text first essentially says: "No":
All
KeptnTaskDefinition
resources at the same level
(either pre-deployment or post-deployment) execute in parallel.
That's very clear.
But then towards the end of the page:
Perhaps you need to run a set of integration tests, a set of performance tests, and a set of regression tests.
Yes, perfect. Let's say I need to run integration tests first then regression (and only if they pass) performance tests.
Define one
KeptnTaskDefinition
resource that runs
integration tests, then regression test, then performance tests
in order.
So, I seem to have two answers: I cannot execute sequentially, but also, I can. Which is it?
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@agardnerIT Thanks for this excellent critique. I did a rewrite of all of this -- see if it makes more sense now. The answer is that all |
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Signed-off-by: Meg McRoberts <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closes #1949
Draft status while I do some rewriting in response to Adam's remarks.
Answers the question: "Is there a way to define a given order for execution post-deployment tasks in Keptn KLT?"