fix(metrics-operator): fix url encoding in DT metrics queries #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
+ Coverage 83.55% 83.58% +0.03%
==========================================
Files 136 136
Lines 8427 8446 +19
==========================================
+ Hits 7041 7060 +19
Misses 1129 1129
Partials 257 257
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
reviewed
Aug 16, 2023
Signed-off-by: Florian Bacher <[email protected]>
This reverts commit 702fb15. Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
|
reverting to draft as this one needs some adaptation due to recently merged changes |
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
commented
Aug 16, 2023
metrics-operator/controllers/common/providers/dynatrace/dynatrace_test.go
Show resolved
Hide resolved
thisthat
reviewed
Aug 21, 2023
metrics-operator/controllers/common/providers/dynatrace/common.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Florian Bacher <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
Aug 21, 2023
odubajDT
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1890
I also cleaned up the unit tests for this component as we had some duplicated scenarios.