DT Metric Query is not executed properly when multiple parameters are provided in spec.query

[bacherfl]

When applying a KeptnMetric with a query that includes multiple parameters, such as the metricSelector and the from attribute, i.e.:

builtin:containers.cpu.throttledMilliCores:avg&from=now-2m

The dynatrace-provider will do an URL encoding of the complete query, rather than on the individual parameters (see

lifecycle-toolkit/metrics-operator/controllers/common/providers/dynatrace/dynatrace.go

Line 45 in 2558f74

query := url.QueryEscape(metric.Spec.Query)

)

This means that the resulting query will look something like:

https://vcj06490.dev.dynatracelabs.com/api/v2/metrics/query?metricSelector=builtin%3Acontainers.cpu.throttledMilliCores%3%29%3Aavg%26from%3Dnow-2m

And the following error will be produced:

{"Response from provider was:": "{\"error\":{\"code\":400,\"message\":\"Metric selector parse error: line 1:324 token recognition error at: '&'\"}}", "error": "provider api response: Metric selector parse error: line 1:324 token recognition error at: '&'"}

This is because of the url encoding of the complete query, the from parameter was interpreted to be part of the metricSelectorparameter.
The correct URL should look as follows:

https://vcj06490.dev.dynatracelabs.com/api/v2/metrics/query?metricSelector=builtin%3Acontainers.cpu.throttledMilliCores%3%29%3Aavg&from=now-2m