-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-operator): add analysis controller #1875
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b3a03f0
to
7a8d49b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
+ Coverage 84.19% 84.23% +0.03%
==========================================
Files 143 149 +6
Lines 9039 9531 +492
==========================================
+ Hits 7610 8028 +418
- Misses 1161 1218 +57
- Partials 268 285 +17
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
4ea5188
to
0644623
Compare
76f1d35
to
0ee481b
Compare
ae97ede
to
0b96337
Compare
a3b5840
to
3cfb8c7
Compare
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
40d541a
to
5c2c079
Compare
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
…ecting timeout Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
this PR implements a working version, but is far from ready, this is why the feature is hidden behind a flag which is disabled in the helm chart.
This PR
introduce an analysis controller:
- first attempt at parallelizing queries to provider: we have different go routines per provider kind. This means that even if the provider of kind prometheus are 4 we query one at a time.
- we store queries results in the status to reduce queries in case of one provider failure and reconciliation
adapts slo computation
adds status to analysis CRD
adds unit tests and a basic integration test
generates all docs
TODOs:
this an example run with integration test not so smart prometheus query and a range of 30 sec