Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Analysis controller #1820

Closed
Tracked by #1646
bacherfl opened this issue Aug 2, 2023 · 1 comment
Closed
Tracked by #1646

Implement Analysis controller #1820

bacherfl opened this issue Aug 2, 2023 · 1 comment
Assignees
Milestone

Comments

@bacherfl
Copy link
Member

bacherfl commented Aug 2, 2023

Implement Analysis controller:

Depends on #1768
Depends on #1769
Depends on #1758

In this ticket, the Analysis controller shall be implemented. The logic of the controller should be as follows:

  • Whenever an Analysis is added/updated, the controller should look for the referenced AnalysisDefinition.
  • When the referenced AnalysisDefinition has been found, the controller should gather all AnalysisValueTemplates required by the AnalysisDefinition.
  • For each of the referenced AnalysisValueTemplates, the controller should use the available implementations of the metric providers to fetch the data using the query specified in the AnalysisValueTemplates, including the timeframe and selectors
    from the Analysis spec.
  • After all values are available, the controller should invoke the scoring function that has been implemented in Implement sloTarget scoring logic to evaluate AnalysisValues based on sloTargets of AnalysisDefinition #1767, and store the result in the
    status of the Analysis. At this point, the Analysis has been reconciled successfully.

DoD

  • Analysis controller is implemented
  • Unit Tests
  • Integration Tests

References

Bigger picture of the concept: #1650

@odubajDT
Copy link
Contributor

odubajDT commented Sep 1, 2023

resolved with #1875

@odubajDT odubajDT closed this as completed Sep 1, 2023
@github-project-automation github-project-automation bot moved this from 🎟️ Refined to ✅ Done in Keptn Lifecycle Toolkit Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants