Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lifecycle-operator): eventing and telemetry #1844

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Aug 6, 2023

Signed-off-by: Giovanni Liva [email protected]

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 5d147f8
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64cfba063751f90008b73b48
😎 Deploy Preview https://deploy-preview-1844--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #1844 (6eda5d4) into main (8eb05c7) will increase coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 64.00%.

❗ Current head 6eda5d4 differs from pull request most recent head 376b59f. Consider uploading reports for the commit 376b59f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
+ Coverage   83.44%   83.45%   +0.01%     
==========================================
  Files         132      132              
  Lines        8210     8215       +5     
==========================================
+ Hits         6851     6856       +5     
  Misses       1106     1106              
  Partials      253      253              
Files Changed Coverage Δ
...e-operator/controllers/common/telemetry/metrics.go 79.41% <ø> (ø)
...perator/controllers/common/telemetry/otel_utils.go 73.83% <ø> (ø)
...erator/controllers/common/telemetry/spanhandler.go 83.33% <ø> (ø)
...trollers/lifecycle/keptntask/job_runner_builder.go 100.00% <ø> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 73.10% <0.00%> (ø)
...ollers/lifecycle/keptntaskdefinition/controller.go 89.13% <ø> (+8.69%) ⬆️
...ifecycle/keptntaskdefinition/reconcile_function.go 71.11% <0.00%> (ø)
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 75.54% <0.00%> (ø)
...rator/controllers/lifecycle/keptnapp/controller.go 63.15% <33.33%> (ø)
...controllers/lifecycle/keptntask/runtime_builder.go 70.44% <33.33%> (ø)
... and 11 more
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.40% <29.16%> (-0.55%) ⬇️
lifecycle-operator 84.92% <60.86%> (+0.01%) ⬆️
metrics-operator 83.02% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thisthat thisthat force-pushed the chore/refactoring-eventing-telemetry branch from c538a25 to e0faf35 Compare August 6, 2023 15:26
@thisthat thisthat changed the title feat: add cloud events endpoint to config chore: refactoring eventing and telemetry Aug 6, 2023
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat marked this pull request as ready for review August 6, 2023 16:55
@thisthat thisthat requested a review from a team as a code owner August 6, 2023 16:55
odubajDT
odubajDT previously approved these changes Aug 7, 2023
Signed-off-by: Giovanni Liva <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies changed the title chore: refactoring eventing and telemetry refactor: eventing and telemetry Aug 7, 2023
@mowies mowies changed the title refactor: eventing and telemetry refactor(lifecycle-operator): eventing and telemetry Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants