Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cluster requirements #1364

Merged
merged 25 commits into from
May 10, 2023
Merged

docs: add cluster requirements #1364

merged 25 commits into from
May 10, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented May 4, 2023

This PR adds some general info to the install files. We need this in a centralized space so we can reference it from the Getting Started Guides and elsewhere:

  • adds a list of tools you may need in your k8s cluster to use KLT. Satisfies add "klt ready" section to install/k8s #1307
  • Adds instructions for checking the k8s version of your cluster, taken from Thomas's original "Getting Started" Guide.

@StackScribe StackScribe added the documentation Improvements or additions to documentation label May 4, 2023
@StackScribe StackScribe requested review from a team as code owners May 4, 2023 05:49
@StackScribe StackScribe self-assigned this May 4, 2023
@StackScribe StackScribe marked this pull request as draft May 4, 2023 05:49
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 5537df9
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/645b7e9d5edc7200080ea5ad
😎 Deploy Preview https://deploy-preview-1364--keptn-lifecycle-toolkit.netlify.app/docs/install/k8s
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@StackScribe StackScribe marked this pull request as ready for review May 4, 2023 06:55
odubajDT and others added 19 commits May 4, 2023 00:44
…ecurityContext (#1290)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…en KeptnTaskDefinition is not found (#1340)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…en KeptnEvaluationDefinition is not found (#1359)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1364 (2c5acf8) into main (d42d023) will decrease coverage by 0.32%.
The diff coverage is 85.71%.

❗ Current head 2c5acf8 differs from pull request most recent head 5537df9. Consider uploading reports for the commit 5537df9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
- Coverage   61.59%   61.27%   -0.32%     
==========================================
  Files         143      138       -5     
  Lines       10698    10474     -224     
==========================================
- Hits         6589     6418     -171     
+ Misses       3848     3805      -43     
+ Partials      261      251      -10     
Impacted Files Coverage Δ
...ollers/common/providers/keptnmetric/keptnmetric.go 85.18% <0.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 40.54% <50.00%> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 78.43% <88.88%> (+1.99%) ⬆️
operator/controllers/common/helperfunctions.go 97.36% <92.30%> (-1.29%) ⬇️
operator/controllers/common/taskhandler.go 79.56% <100.00%> (ø)

... and 23 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.28% <ø> (-4.27%) ⬇️
component-tests 59.87% <70.00%> (+0.77%) ⬆️
lifecycle-operator 82.52% <81.63%> (+0.01%) ⬆️
metrics-operator 77.80% <ø> (-0.10%) ⬇️
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

agardnerIT
agardnerIT previously approved these changes May 10, 2023
thisthat
thisthat previously approved these changes May 10, 2023
bacherfl
bacherfl previously approved these changes May 10, 2023
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe dismissed stale reviews from bacherfl, thisthat, and agardnerIT via 06f8245 May 10, 2023 11:02
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@StackScribe StackScribe merged commit e06b01e into keptn:main May 10, 2023
@StackScribe StackScribe deleted the 0503-cluster-reqs branch May 10, 2023 13:34
@keptn-bot keptn-bot mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants