-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for multiple metrics providers #1193
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 58.94% 59.52% +0.57%
==========================================
Files 128 133 +5
Lines 10040 10144 +104
==========================================
+ Hits 5918 6038 +120
+ Misses 3902 3888 -14
+ Partials 220 218 -2
... and 7 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
5d91dae
to
394ae99
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
…operator API versions Signed-off-by: Moritz Wiesinger <[email protected]>
…s into separate file Signed-off-by: Moritz Wiesinger <[email protected]>
66d606c
to
0b0dfff
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
…der and a real query, remove badmetric Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
…ype work Signed-off-by: Moritz Wiesinger <[email protected]>
36ecbb6
to
4d74a41
Compare
Co-authored-by: odubajDT <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: odubajDT <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome job :)
Signed-off-by: Moritz Wiesinger <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
This PR
type
field in the metrics providertype
field so that it can only have valid metrics provider values (i.e.prometheus | dynatrace | dql | datadog
)metrics.keptn.sh
API group (v1alpha3
)metrics.keptn.sh/v1alpha3
metrics
kuttl integration test by removing the obsolete badmetric check and replacing it with checks for multiple providers with the same type and different names to ensure backwards compatibility of the featureFixes #1144
Docs will be updated in a separate PR