-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric Server :: Support Multiple Providers #1144
Comments
thisthat
added
enhancement
New feature or request
status: ready-for-refinement
Issue is relevant for the next backlog refinment
labels
Mar 29, 2023
How will multiple Prometheus (for example) appear elsewhere in the cluster? Will there be multiple *name fields in the metadata so the user can define names? |
mowies
changed the title
Metric Server :: Support Multiple Provider
Metric Server :: Support Multiple Providers
Mar 30, 2023
thisthat
added
metrics-operator
and removed
status: ready-for-refinement
Issue is relevant for the next backlog refinment
labels
Apr 4, 2023
Is this issue open fo grabs? |
I think we will handle this issue in the core maintainer team, sorry 😇 |
This was referenced Apr 18, 2023
github-project-automation
bot
moved this from 🏃 In progress
to ✅ Done
in Keptn Lifecycle Toolkit
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Goal
Support multiple provider instances.
Technical Details
Currently, an evaluation can support multiple providers, but only a single instance of each provider can be configured, e.g., as a user, I cannot have two different Prometheus installations.
The
KeptnMetric
CRD has a fieldspec.provider.name
which is used to decide which provider among Prometheus, Dynatrace, and Datatog is used. Similarly, theKeptnMetricsProvider
requires a CR to have themetadata.name
equal to one of the supported Observability platforms.KeptnMetricProvider
CRD shall provide a new fieldspec.type
that can be only one of the supported Observability platforms.The controller should then change behavior and use the new field to decide which implementation to use for fetching the metrics.
The
spec.provider.name
is used only to match theKeptnMetricsProvider
CR configuration.Acceptance Criteria
spec.type
spec.type
field to check that has one of the following:dynatrace|datadog|prometheus|dql
DoD
The text was updated successfully, but these errors were encountered: