Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Server :: Support Multiple Providers #1144

Closed
5 tasks done
thisthat opened this issue Mar 29, 2023 · 3 comments · Fixed by #1193
Closed
5 tasks done

Metric Server :: Support Multiple Providers #1144

thisthat opened this issue Mar 29, 2023 · 3 comments · Fixed by #1193
Assignees
Labels
enhancement New feature or request metrics-operator
Milestone

Comments

@thisthat
Copy link
Member

thisthat commented Mar 29, 2023

Goal

Support multiple provider instances.

Technical Details

Currently, an evaluation can support multiple providers, but only a single instance of each provider can be configured, e.g., as a user, I cannot have two different Prometheus installations.

The KeptnMetric CRD has a field spec.provider.name which is used to decide which provider among Prometheus, Dynatrace, and Datatog is used. Similarly, the KeptnMetricsProvider requires a CR to have the metadata.name equal to one of the supported Observability platforms.

KeptnMetricProvider CRD shall provide a new field spec.type that can be only one of the supported Observability platforms.
The controller should then change behavior and use the new field to decide which implementation to use for fetching the metrics.
The spec.provider.name is used only to match the KeptnMetricsProvider CR configuration.

Acceptance Criteria

  • New CRD version and set it as hub version
  • Controller and CRD are updated to support spec.type
  • Add validation for the spec.type field to check that has one of the following: dynatrace|datadog|prometheus|dql

DoD

  • Multiple provider instances can be used
  • Unit/Component/Kuttl tests
@thisthat thisthat added enhancement New feature or request status: ready-for-refinement Issue is relevant for the next backlog refinment labels Mar 29, 2023
@thisthat thisthat added this to the 0.8 milestone Mar 29, 2023
@thisthat thisthat moved this to 🏗 Shaping in Keptn Lifecycle Toolkit Mar 29, 2023
@thisthat thisthat moved this from Backlog to In Progress in 🛣️ Keptn Roadmap Mar 29, 2023
@StackScribe
Copy link
Contributor

How will multiple Prometheus (for example) appear elsewhere in the cluster? Will there be multiple *name fields in the metadata so the user can define names?

@mowies mowies changed the title Metric Server :: Support Multiple Provider Metric Server :: Support Multiple Providers Mar 30, 2023
@thisthat thisthat added metrics-operator and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Apr 4, 2023
@thisthat thisthat moved this from 🏗 Shaping to 🎟️ Refined in Keptn Lifecycle Toolkit Apr 4, 2023
@rakshitgondwal
Copy link
Member

Is this issue open fo grabs?

@mowies
Copy link
Member

mowies commented Apr 6, 2023

I think we will handle this issue in the core maintainer team, sorry 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metrics-operator
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants