fix: move prometheus install into make file #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealAnna
requested review from
thisthat,
thschue,
bacherfl,
mowies and
philipp-hinteregger
as code owners
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
=======================================
Coverage 58.91% 58.92%
=======================================
Files 126 126
Lines 10007 10007
=======================================
+ Hits 5896 5897 +1
- Misses 3893 3895 +2
+ Partials 218 215 -3 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
reviewed
Mar 23, 2023
odubajDT
previously approved these changes
Mar 23, 2023
…n tests Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
RealAnna
force-pushed
the
fix/local_test_runnable
branch
from
a94814d to
6e2df99
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mowies
approved these changes
Mar 27, 2023
Merged
aepfli
pushed a commit
to aepfli/lifecycle-toolkit
that referenced
this pull request
Mar 30, 2023
Signed-off-by: realanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1085
kind create clusterhelm upgrade --install klt klt/klt -n keptn-lifecycle-toolkit-system --create-namespacemake integration-test-localnow Prometheus is installed before running so all tests pass locally