fix: pr review

Signed-off-by: realanna <[email protected]>
keptn · Mar 23, 2023 · 6e2df99 · 6e2df99
1 parent 8a1be3c
commit 6e2df99
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/actions/deploy-prometheus-on-cluster/action.yml b/.github/actions/deploy-prometheus-on-cluster/action.yml
@@ -7,6 +7,10 @@ runs:
       shell: bash
       run: |
         make install-prometheus
+        
+        kubectl -n monitoring port-forward svc/prometheus-k8s 9090 &
+        kubectl -n monitoring port-forward svc/node-exporter 9100 &
+        
         # wait for port 9090 to become available
         while ! nc -vz localhost 9090 > /dev/null 2>&1 ; do
         echo "Sleeping until port-forward for Prometheus at port 9090 is ready..."

diff --git a/Makefile b/Makefile
@@ -56,8 +56,7 @@ install-prometheus:
 	kubectl wait --for=condition=available deployment/prometheus-adapter -n monitoring --timeout=120s
 	kubectl wait --for=condition=available deployment/kube-state-metrics -n monitoring --timeout=120s
 	kubectl wait pod/prometheus-k8s-0 --for=condition=ready --timeout=120s -n monitoring
-	kubectl -n monitoring port-forward svc/prometheus-k8s 9090 &
-	kubectl -n monitoring port-forward svc/node-exporter 9100 &
+
 
 
 .PHONY: cleanup-manifests