modify step condition

Signed-off-by: Rakshit Gondwal <[email protected]>
keptn · Jul 21, 2023 · a991ce1 · a991ce1
1 parent e61b9f8
commit a991ce1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/metrics-operator/api/v1alpha3/keptnmetric_webhook.go b/metrics-operator/api/v1alpha3/keptnmetric_webhook.go
@@ -97,7 +97,7 @@ func (s *KeptnMetric) validateRangeInterval() *field.Error {
 }
 
 func (s *KeptnMetric) validateRangeStep() *field.Error {
-	if s.Spec.Range == nil {
+	if s.Spec.Range == nil || s.Spec.Range.Step == "" {
 		return nil
 	}
 	_, err := time.ParseDuration(s.Spec.Range.Step)

diff --git a/metrics-operator/api/v1alpha3/keptnmetric_webhook_test.go b/metrics-operator/api/v1alpha3/keptnmetric_webhook_test.go
@@ -181,17 +181,6 @@ func TestKeptnMetric_validateRangeStep(t *testing.T) {
 					Step:     "",
 				},
 			},
-			want: apierrors.NewInvalid(
-				schema.GroupKind{Group: "metrics.keptn.sh", Kind: "KeptnMetric"},
-				"create-with-empty-step",
-				field.ErrorList{
-					field.Invalid(
-						field.NewPath("spec").Child("range").Child("step"),
-						"",
-						"Forbidden! The time interval cannot be parsed. Please check for suitable conventions",
-					),
-				},
-			),
 		},
 		{
 			name: "create-with-right-step",