chore: introduce script to re-generate helm results (#3297)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>

.github/scripts/generate-helm-results.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+echo "re-generating Helm test results"
+tests=$(find ./.github/scripts/.helm-tests -maxdepth 1 -mindepth 1 -type d )
+
+# shellcheck source=.github/scripts/helm-utils.sh
+source .github/scripts/helm-utils.sh
+
+performHelmRepoUpdate
+
+for test in $tests
+do
+  echo "Re-generating $test"
+  helm template keptn-test --namespace helmtests -f $test/values.yaml ./chart > $test/result.yaml
+done

.github/scripts/helm-test.sh

@@ -5,28 +5,17 @@
 # This script supports the comparison of standard values and expected templated results to helm chart
 # it is used to make sure changes to the chart are intentional and produce expected outcomes
 
+# shellcheck source=./.github/scripts/helm-utils.sh
+source ./.github/scripts/helm-utils.sh
+
 echo "running Helm tests"
   tests=$(find ./.github/scripts/.helm-tests -maxdepth 1 -mindepth 1 -type d )
 
   errors=0
   successful=0
   failures=""
 
-    helm repo add keptn "https://charts.lifecycle.keptn.sh"
-    helm repo update
-
-    for chart_dir in ./lifecycle-operator/chart \
-            ./metrics-operator/chart \
-            ./keptn-cert-manager/chart \
-            ./chart; do
-        # shellcheck disable=SC2164
-        cd "$chart_dir"
-        echo "updating charts for" $chart_dir
-        helm dependency update
-        helm dependency build
-        # shellcheck disable=SC2164
-        cd -  # Return to the previous directory
-    done
+  performHelmRepoUpdate
 
   for test in $tests
   do

.github/scripts/helm-utils.sh

@@ -0,0 +1,19 @@
+#!/bin/bash
+
+performHelmRepoUpdate () {
+    helm repo add keptn "https://charts.lifecycle.keptn.sh"
+    helm repo update
+
+    for chart_dir in ./lifecycle-operator/chart \
+            ./metrics-operator/chart \
+            ./keptn-cert-manager/chart \
+            ./chart; do
+        # shellcheck disable=SC2164
+        cd "$chart_dir"
+        echo "updating charts for" $chart_dir
+        helm dependency update
+        helm dependency build
+        # shellcheck disable=SC2164
+        cd -  # Return to the previous directory
+    done
+}

.github/workflows/validate-helm-chart.yml

@@ -76,4 +76,4 @@ jobs:
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
       - name: Check if Helm template is up to date
-        run: ./.github/scripts/helm-test.sh
+        run: make helm-test

Makefile

@@ -178,6 +178,14 @@ operator-lint: install-golangci-lint
 scheduler-lint: install-golangci-lint
 	$(MAKE) -C scheduler lint
 
+.PHONY: helm-test
+helm-test:
+	./.github/scripts/helm-test.sh
+
+.PHONY: generate-helm-test-results
+generate-helm-test-results:
+	./.github/scripts/generate-helm-results.sh
+
 .PHONY: lint
 lint: metrics-operator-lint
 lint: certmanager-lint