pr review

Signed-off-by: odubajDT <[email protected]>
keptn · Oct 18, 2022 · 6d2289c · 6d2289c
1 parent 4d2830a
commit 6d2289c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/operator/config/manager/manager.yaml b/operator/config/manager/manager.yaml
@@ -47,7 +47,7 @@ spec:
           - name: OTEL_COLLECTOR_URL
             value: otel-collector:4317
           - name: FUNCTION_RUNNER_IMAGE
-            value: docker.io/keptn-sandbox/functions-runtime:0.2.0 #x-release-please-version
+            value: ghcr.io/keptn-sandbox/functions-runtime:v0.2.0 #x-release-please-version
         securityContext:
           allowPrivilegeEscalation: false
           capabilities:

diff --git a/operator/controllers/keptnevaluation/controller.go b/operator/controllers/keptnevaluation/controller.go
@@ -106,7 +106,7 @@ func (r *KeptnEvaluationReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 		span.SetStatus(codes.Error, err.Error())
 		evaluation.Status.OverallStatus = common.StateFailed
 		r.updateFinishedEvaluationMetrics(ctx, evaluation, span)
-		return ctrl.Result{}, err
+		return ctrl.Result{}, nil
 	}
 
 	if !evaluation.Status.OverallStatus.IsSucceeded() {