pr review

Signed-off-by: Florian Bacher <[email protected]>
keptn · Mar 28, 2023 · 6a18c30 · 6a18c30
1 parent 7eb7694
commit 6a18c30
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/operator/apis/lifecycle/v1alpha3/keptnappcreationrequest_types.go b/operator/apis/lifecycle/v1alpha3/keptnappcreationrequest_types.go
@@ -25,9 +25,6 @@ import (
 
 // KeptnAppCreationRequestSpec defines the desired state of KeptnAppCreationRequest
 type KeptnAppCreationRequestSpec struct {
-	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
-	// Important: Run "make" to regenerate code after modifying this file
-
 	// AppName is the name of the KeptnApp the KeptnAppCreationRequest should create if no user-defined object with that name is found.
 	AppName string `json:"appName"`
 }

diff --git a/operator/controllers/lifecycle/keptnappcreationrequest/controller.go b/operator/controllers/lifecycle/keptnappcreationrequest/controller.go
@@ -24,7 +24,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
-	"sigs.k8s.io/controller-runtime/pkg/log"
 )
 
 // KeptnAppCreationRequestReconciler reconciles a KeptnAppCreationRequest object
@@ -47,8 +46,6 @@ type KeptnAppCreationRequestReconciler struct {
 // For more details, check Reconcile and its Result here:
 // - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/reconcile
 func (r *KeptnAppCreationRequestReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
-	_ = log.FromContext(ctx)
-
 	return ctrl.Result{}, nil
 }
 

diff --git a/test/integration/app-creation-request/00-assert.yaml b/test/integration/app-creation-request/00-assert.yaml
@@ -3,4 +3,4 @@ kind: KeptnAppCreationRequest
 metadata:
   name: my-kacr
 spec:
-  appName: my-app
+  appName: my-app
diff --git a/test/integration/app-creation-request/00-install.yaml b/test/integration/app-creation-request/00-install.yaml
@@ -3,4 +3,4 @@ kind: KeptnAppCreationRequest
 metadata:
   name: my-kacr
 spec:
-  appName: my-app
+  appName: my-app