fix(operator): Use correct parent/child span relationship

Signed-off-by: Giovanni Liva <[email protected]>
keptn · Nov 15, 2022 · 2579c76 · 2579c76
1 parent c4502e1
commit 2579c76
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/operator/controllers/common/phasehandler.go b/operator/controllers/common/phasehandler.go
@@ -41,7 +41,7 @@ func (r PhaseHandler) HandlePhase(ctx context.Context, ctxAppTrace context.Conte
 	piWrapper.SetCurrentPhase(phase.ShortName)
 
 	r.Log.Info(phase.LongName + " not finished")
-	ctxAppTrace, spanAppTrace, err := r.SpanHandler.GetSpan(ctxAppTrace, tracer, reconcileObject, phase.ShortName)
+	_, spanAppTrace, err := r.SpanHandler.GetSpan(ctxAppTrace, tracer, reconcileObject, phase.ShortName)
 	if err != nil {
 		r.Log.Error(err, "could not get span")
 	}

diff --git a/operator/controllers/keptnappversion/controller.go b/operator/controllers/keptnappversion/controller.go
@@ -117,7 +117,8 @@ func (r *KeptnAppVersionReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 			r.Log.Error(err, "cannot unbind span")
 		}
 		var spanAppTrace trace.Span
-		ctxAppTrace, spanAppTrace, err = r.SpanHandler.GetSpan(ctxAppTrace, r.Tracer, appVersion, phase.ShortName)
+		// ignoring ctx to don't use this as parent span
+		_, spanAppTrace, err = r.SpanHandler.GetSpan(ctxAppTrace, r.Tracer, appVersion, phase.ShortName)
 		if err != nil {
 			r.Log.Error(err, "could not get span")
 		}