This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(webhook-service): Disallow @ file uploads inside data block
#7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * added failing test cases Signed-off-by: warber <[email protected]> * fix: disallow @ in data block Signed-off-by: warber <[email protected]> * fixed if condition when checking for data block Signed-off-by: warber <[email protected]> * additional tests Signed-off-by: warber <[email protected]> * incorp. review comment Signed-off-by: warber <[email protected]> (cherry picked from commit aa0f71e)
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## 0.13.x #7162 +/- ##
==========================================
+ Coverage 57.75% 57.77% +0.01%
==========================================
Files 508 508
Lines 29317 29329 +12
Branches 1381 1381
==========================================
+ Hits 16932 16944 +12
Misses 11175 11175
Partials 1210 1210
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
approved these changes
Mar 15, 2022
thisthat
changed the title
@ file uploads inside data block (#7…@ file uploads inside data block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #7158