This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(shipyard-controller): Do not reset subscriptions when updating distributor/integration version #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case of version update Signed-off-by: Florian Bacher <[email protected]>
…on upgrade Signed-off-by: Florian Bacher <[email protected]>
…on upgrade Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
added
the
CI:trigger-build-everything
Signed-off-by: Florian Bacher <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 0.12.x #7046 +/- ##
=======================================
Coverage 57.45% 57.45%
=======================================
Files 486 486
Lines 27804 27838 +34
Branches 1295 1295
=======================================
+ Hits 15974 15994 +20
- Misses 10648 10658 +10
- Partials 1182 1186 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
warber
reviewed
Mar 3, 2022
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
BREAKING CHANGES: The Keptn Helm charts are now served from the [keptn/helm-charts](https://github.com/keptn/helm-charts) repository through GitHub pages. They are accessible by using https://charts.keptn.sh as a helm chart repository. Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
…6670) Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
(cherry picked from commit 134d487) Signed-off-by: Moritz Wiesinger <[email protected]>
) (cherry picked from commit 59a7762) Signed-off-by: Moritz Wiesinger <[email protected]>
(cherry picked from commit e55355f) Signed-off-by: Moritz Wiesinger <[email protected]>
… clusterrolebindings (#6931) (cherry picked from commit 3dd71e5) Signed-off-by: Moritz Wiesinger <[email protected]>
(cherry picked from commit 0609c7d) Signed-off-by: Moritz Wiesinger <[email protected]>
…I pipeline runs in the source branch (#6966) (cherry picked from commit 23c4c37) Signed-off-by: Moritz Wiesinger <[email protected]>
…e empty (#6971) (cherry picked from commit 2abb21c) Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…case of version update Signed-off-by: Florian Bacher <[email protected]>
…on upgrade Signed-off-by: Florian Bacher <[email protected]>
…on upgrade Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…/keptn into fix/uniform-version-update
# Conflicts: # test/go-tests/test_utils.go
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
Mar 3, 2022
bacherfl
added a commit
that referenced
this pull request
Mar 3, 2022
…stributor/integration version (#7046) * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * ci: Add pipeline to nightly check docker image digests (#6598) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Minor pipeline improvements (#6613) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only push docker images if not from a forked repo (#6618) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix digest checker pipeline (#6619) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix CI pipeline not pushing master images to registry (#6634) Signed-off-by: Moritz Wiesinger <[email protected]> * feat: Release helm charts on GitHub pages (#6559) BREAKING CHANGES: The Keptn Helm charts are now served from the [keptn/helm-charts](https://github.com/keptn/helm-charts) repository through GitHub pages. They are accessible by using https://charts.keptn.sh as a helm chart repository. Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Remove unneeded pipelines and config files (#6642) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6643) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6659) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix intergation tests taking master artifacts from bot commits (#6670) Signed-off-by: Moritz Wiesinger <[email protected]> * test: Integration Tests on static GKE clusters (#6632) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Add k8s resource stats to release notes (#6718) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix dev helm charts not having a unique image name (#6816) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Disable manual triggers of the CI pipeline (#6819) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Always use datetimed version for integration tests (#6820) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Ensure that build matrix runs as far as possible (#6875) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only upload dev helm chart for non-fork PRs (#6763) (cherry picked from commit 134d487) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Push dev images to dev dockerhub registry, adjust helm charts (#6857) (cherry picked from commit 59a7762) Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Removed makefile and all usages of it (#6804) (cherry picked from commit e55355f) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix cleanup in integration tests to also include clusterroles and clusterrolebindings (#6931) (cherry picked from commit 3dd71e5) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix release pipeline not uploading helm charts correctly (#6944) (cherry picked from commit 0609c7d) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix integration test pipeline not starting if there were 404ing CI pipeline runs in the source branch (#6966) (cherry picked from commit 23c4c37) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix resource cleanup in integration tests when resource arrays are empty (#6971) (cherry picked from commit 2abb21c) Signed-off-by: Moritz Wiesinger <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> (cherry picked from commit a5a62ee)
bacherfl
added a commit
that referenced
this pull request
Mar 3, 2022
…stributor/integration version (#7046) * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * ci: Add pipeline to nightly check docker image digests (#6598) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Minor pipeline improvements (#6613) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only push docker images if not from a forked repo (#6618) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix digest checker pipeline (#6619) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix CI pipeline not pushing master images to registry (#6634) Signed-off-by: Moritz Wiesinger <[email protected]> * feat: Release helm charts on GitHub pages (#6559) BREAKING CHANGES: The Keptn Helm charts are now served from the [keptn/helm-charts](https://github.com/keptn/helm-charts) repository through GitHub pages. They are accessible by using https://charts.keptn.sh as a helm chart repository. Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Remove unneeded pipelines and config files (#6642) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6643) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6659) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix intergation tests taking master artifacts from bot commits (#6670) Signed-off-by: Moritz Wiesinger <[email protected]> * test: Integration Tests on static GKE clusters (#6632) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Add k8s resource stats to release notes (#6718) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix dev helm charts not having a unique image name (#6816) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Disable manual triggers of the CI pipeline (#6819) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Always use datetimed version for integration tests (#6820) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Ensure that build matrix runs as far as possible (#6875) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only upload dev helm chart for non-fork PRs (#6763) (cherry picked from commit 134d487) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Push dev images to dev dockerhub registry, adjust helm charts (#6857) (cherry picked from commit 59a7762) Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Removed makefile and all usages of it (#6804) (cherry picked from commit e55355f) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix cleanup in integration tests to also include clusterroles and clusterrolebindings (#6931) (cherry picked from commit 3dd71e5) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix release pipeline not uploading helm charts correctly (#6944) (cherry picked from commit 0609c7d) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix integration test pipeline not starting if there were 404ing CI pipeline runs in the source branch (#6966) (cherry picked from commit 23c4c37) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix resource cleanup in integration tests when resource arrays are empty (#6971) (cherry picked from commit 2abb21c) Signed-off-by: Moritz Wiesinger <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> (cherry picked from commit a5a62ee)
bacherfl
added a commit
that referenced
this pull request
Mar 4, 2022
…stributor/integration version (#7046) (#7059) * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * ci: Add pipeline to nightly check docker image digests (#6598) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Minor pipeline improvements (#6613) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only push docker images if not from a forked repo (#6618) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix digest checker pipeline (#6619) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix CI pipeline not pushing master images to registry (#6634) Signed-off-by: Moritz Wiesinger <[email protected]> * feat: Release helm charts on GitHub pages (#6559) BREAKING CHANGES: The Keptn Helm charts are now served from the [keptn/helm-charts](https://github.com/keptn/helm-charts) repository through GitHub pages. They are accessible by using https://charts.keptn.sh as a helm chart repository. Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Remove unneeded pipelines and config files (#6642) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6643) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6659) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix intergation tests taking master artifacts from bot commits (#6670) Signed-off-by: Moritz Wiesinger <[email protected]> * test: Integration Tests on static GKE clusters (#6632) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Add k8s resource stats to release notes (#6718) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix dev helm charts not having a unique image name (#6816) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Disable manual triggers of the CI pipeline (#6819) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Always use datetimed version for integration tests (#6820) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Ensure that build matrix runs as far as possible (#6875) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only upload dev helm chart for non-fork PRs (#6763) (cherry picked from commit 134d487) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Push dev images to dev dockerhub registry, adjust helm charts (#6857) (cherry picked from commit 59a7762) Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Removed makefile and all usages of it (#6804) (cherry picked from commit e55355f) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix cleanup in integration tests to also include clusterroles and clusterrolebindings (#6931) (cherry picked from commit 3dd71e5) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix release pipeline not uploading helm charts correctly (#6944) (cherry picked from commit 0609c7d) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix integration test pipeline not starting if there were 404ing CI pipeline runs in the source branch (#6966) (cherry picked from commit 23c4c37) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix resource cleanup in integration tests when resource arrays are empty (#6971) (cherry picked from commit 2abb21c) Signed-off-by: Moritz Wiesinger <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> (cherry picked from commit a5a62ee)
bacherfl
added a commit
that referenced
this pull request
Mar 7, 2022
…stributor/integration version (#7046) (#7058) * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * ci: Add pipeline to nightly check docker image digests (#6598) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Minor pipeline improvements (#6613) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only push docker images if not from a forked repo (#6618) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix digest checker pipeline (#6619) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix CI pipeline not pushing master images to registry (#6634) Signed-off-by: Moritz Wiesinger <[email protected]> * feat: Release helm charts on GitHub pages (#6559) BREAKING CHANGES: The Keptn Helm charts are now served from the [keptn/helm-charts](https://github.com/keptn/helm-charts) repository through GitHub pages. They are accessible by using https://charts.keptn.sh as a helm chart repository. Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Remove unneeded pipelines and config files (#6642) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6643) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix master builds not pushing docker images (#6659) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix intergation tests taking master artifacts from bot commits (#6670) Signed-off-by: Moritz Wiesinger <[email protected]> * test: Integration Tests on static GKE clusters (#6632) Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Add k8s resource stats to release notes (#6718) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix dev helm charts not having a unique image name (#6816) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Disable manual triggers of the CI pipeline (#6819) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Always use datetimed version for integration tests (#6820) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Ensure that build matrix runs as far as possible (#6875) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Only upload dev helm chart for non-fork PRs (#6763) (cherry picked from commit 134d487) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Push dev images to dev dockerhub registry, adjust helm charts (#6857) (cherry picked from commit 59a7762) Signed-off-by: Moritz Wiesinger <[email protected]> * chore: Removed makefile and all usages of it (#6804) (cherry picked from commit e55355f) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix cleanup in integration tests to also include clusterroles and clusterrolebindings (#6931) (cherry picked from commit 3dd71e5) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix release pipeline not uploading helm charts correctly (#6944) (cherry picked from commit 0609c7d) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix integration test pipeline not starting if there were 404ing CI pipeline runs in the source branch (#6966) (cherry picked from commit 23c4c37) Signed-off-by: Moritz Wiesinger <[email protected]> * ci: Fix resource cleanup in integration tests when resource arrays are empty (#6971) (cherry picked from commit 2abb21c) Signed-off-by: Moritz Wiesinger <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * fix(shipyard-controller): Do not overwrite existing subscriptions in case of version update Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * added assertion to check if subscriptions are still there after version upgrade Signed-off-by: Florian Bacher <[email protected]> * fixed typo Signed-off-by: Florian Bacher <[email protected]> * fixed sonar warnings Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> * pr review Signed-off-by: Florian Bacher <[email protected]> * added unit test for repo implementation Signed-off-by: Florian Bacher <[email protected]> * added comment Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> (cherry picked from commit a5a62ee)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7047
This PR ensures that if the version of the distributor and/or the integration has changed, the previously set up subscriptions will not be overwritten with an empty array