This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 244
feat(bridge): Add checkbox to set the sendFinished
flag (#5735)
#5989
Merged
ermin-muratovic
merged 23 commits into
master
from
feature/5735/send-finished-flag-webhook-config
Nov 17, 2021
Merged
feat(bridge): Add checkbox to set the sendFinished
flag (#5735)
#5989
ermin-muratovic
merged 23 commits into
master
from
feature/5735/send-finished-flag-webhook-config
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5989 +/- ##
==========================================
- Coverage 53.84% 53.15% -0.69%
==========================================
Files 333 326 -7
Lines 22703 22314 -389
Branches 1103 1108 +5
==========================================
- Hits 12224 11862 -362
+ Misses 9569 9550 -19
+ Partials 910 902 -8
|
Signed-off-by: ermin.muratovic <[email protected]>
@ermin-muratovic when this PR goes into a review round, please let me know since I would like to review it too. |
johannes-b
reviewed
Nov 12, 2021
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.html
Outdated
Show resolved
Hide resolved
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Kirdock
suggested changes
Nov 12, 2021
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.ts
Outdated
Show resolved
Hide resolved
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Kirdock
suggested changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[deleted]
Signed-off-by: ermin.muratovic <[email protected]>
Kirdock
suggested changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bridge/client/app/_components/ktb-webhook-settings/ktb-webhook-settings.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Kirdock
previously approved these changes
Nov 17, 2021
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Kirdock
approved these changes
Nov 17, 2021
ermin-muratovic
deleted the
feature/5735/send-finished-flag-webhook-config
branch
November 17, 2021 12:16
Docker Build Report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
sendFinished
flagRelated Issues
Fixes #5735