Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(bridge): Add checkbox to set the sendFinished flag (#5735) #5989

Merged
merged 23 commits into from
Nov 17, 2021

Conversation

ermin-muratovic
Copy link
Member

@ermin-muratovic ermin-muratovic commented Nov 11, 2021

This PR

  • adds a checkbox to the webhook settings page to set the sendFinished flag

Related Issues

Fixes #5735

image

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #5989 (8571b0c) into master (aa7b4fa) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5989      +/-   ##
==========================================
- Coverage   53.84%   53.15%   -0.69%     
==========================================
  Files         333      326       -7     
  Lines       22703    22314     -389     
  Branches     1103     1108       +5     
==========================================
- Hits        12224    11862     -362     
+ Misses       9569     9550      -19     
+ Partials      910      902       -8     
Impacted Files Coverage Δ
bridge/shared/models/webhook-config.ts 100.00% <ø> (ø)
...ption/ktb-modify-uniform-subscription.component.ts 100.00% <100.00%> (ø)
...webhook-settings/ktb-webhook-settings.component.ts 100.00% <100.00%> (ø)
bridge/client/app/app.module.ts 100.00% <100.00%> (ø)
cli/cmd/version.go 47.27% <0.00%> (-13.26%) ⬇️
cli/cmd/root.go 63.10% <0.00%> (-6.21%) ⬇️
cli/pkg/config/cli_config.go 51.61% <0.00%> (-6.14%) ⬇️
shipyard-controller/handler/sequencedispatcher.go 68.25% <0.00%> (-3.97%) ⬇️
shipyard-controller/handler/shipyardcontroller.go 53.62% <0.00%> (-3.01%) ⬇️
...-service/event_handler/start_evaluation_handler.go 62.04% <0.00%> (-1.11%) ⬇️
... and 35 more

Signed-off-by: ermin.muratovic <[email protected]>
@johannes-b
Copy link
Member

@ermin-muratovic when this PR goes into a review round, please let me know since I would like to review it too.

Copy link
Contributor

@Kirdock Kirdock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleted]

Signed-off-by: ermin.muratovic <[email protected]>
Copy link
Contributor

@Kirdock Kirdock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radio boxes for Send finished event have different behavior depending on if it is just edited or loaded.

When the suffix is set to started:
image

After reloading:
image

Signed-off-by: ermin.muratovic <[email protected]>
Signed-off-by: ermin.muratovic <[email protected]>
Kirdock
Kirdock previously approved these changes Nov 17, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ermin-muratovic ermin-muratovic merged commit 89598f8 into master Nov 17, 2021
@ermin-muratovic ermin-muratovic deleted the feature/5735/send-finished-flag-webhook-config branch November 17, 2021 12:16
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2021

Docker Build Report

  • Pushed keptn/bridge2:0.10.1-dev-PR-5989.202111171159 and keptn/bridge2:0.10.1-dev-PR-5989 (Source: bridge/)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge: Add checkbox to set the sendFinished flag
3 participants