This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix(webhook-service): Disallow @ file uploads inside data block
#7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: warber <[email protected]>
Signed-off-by: warber <[email protected]>
warber
added
the
CI:trigger-build-everything
Codecov Report
@@ Coverage Diff @@
## master #7158 +/- ##
==========================================
+ Coverage 58.53% 58.55% +0.01%
==========================================
Files 528 528
Lines 30732 30744 +12
Branches 1508 1508
==========================================
+ Hits 17990 18001 +11
Misses 11474 11474
- Partials 1268 1269 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: warber <[email protected]>
odubajDT
previously approved these changes
Mar 15, 2022
Signed-off-by: warber <[email protected]>
thisthat
previously approved these changes
Mar 15, 2022
warber
removed
the
CI:trigger-build-everything
Signed-off-by: warber <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
Mar 15, 2022
warber
added a commit
that referenced
this pull request
Mar 15, 2022
) * added failing test cases Signed-off-by: warber <[email protected]> * fix: disallow @ in data block Signed-off-by: warber <[email protected]> * fixed if condition when checking for data block Signed-off-by: warber <[email protected]> * additional tests Signed-off-by: warber <[email protected]> * incorp. review comment Signed-off-by: warber <[email protected]> (cherry picked from commit aa0f71e)
warber
added a commit
that referenced
this pull request
Mar 15, 2022
) * added failing test cases Signed-off-by: warber <[email protected]> * fix: disallow @ in data block Signed-off-by: warber <[email protected]> * fixed if condition when checking for data block Signed-off-by: warber <[email protected]> * additional tests Signed-off-by: warber <[email protected]> * incorp. review comment Signed-off-by: warber <[email protected]> (cherry picked from commit aa0f71e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains additional checks for disallowing the usage of
@inside--dataargument of curl