Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Bridge: FF for OIDC #6073

Closed
2 tasks done
thisthat opened this issue Nov 22, 2021 · 0 comments · Fixed by #6285
Closed
2 tasks done

Bridge: FF for OIDC #6073

thisthat opened this issue Nov 22, 2021 · 0 comments · Fixed by #6285
Assignees
@Kirdock
Labels
bridge.2.0 Bridge Version 2 kep:60
Milestone
0.12.0 (Bridge)

Comments

@thisthat
Copy link
Member

thisthat commented Nov 22, 2021 •
edited by Kirdock
Loading

Action Item

The Bridge should provide a FF to enable/disable OIDC. The value of this flag is based on the value of the helm chart bridge.oauth.enabled (env var OAUTH_ENABLED) and defaults to false in case this value is not provided.

Technical details

The FF shall be moved to the Bridge-server. For more details, see #5708
The server sends the FF as part of the metadata.
The server should compute a FF with the following priority: env var >> config file >> default value, e.g.:

const orci = process.env.ENV_VAR ?? fileConfig.FeatureFlag ?? false;

DoD

  • The FF is implemented
  • Unit Tests
@thisthat thisthat added bridge.2.0 Bridge Version 2 ready-for-refinement Issue is relevant for the next backlog refinment kep:60 labels Nov 22, 2021
This was referenced Nov 22, 2021
Closed
Closed
@thisthat thisthat mentioned this issue Dec 3, 2021
Closed
1 task
@Kirdock Kirdock self-assigned this Dec 6, 2021
@Kirdock Kirdock removed the ready-for-refinement Issue is relevant for the next backlog refinment label Dec 6, 2021
Kirdock added a commit that referenced this issue Dec 6, 2021
@Kirdock
feat(bridge): Feature flags for bridge server (#6073)
ed983a7 
Signed-off-by: Klaus Strießnig <[email protected]>
@Kirdock Kirdock mentioned this issue Dec 6, 2021
Merged
Kirdock added a commit that referenced this issue Dec 7, 2021
@Kirdock
feat(bridge): Feature flags for bridge server (#6073)
6351a58 
* feat(bridge): Feature flags for bridge server (#6073)

Signed-off-by: Klaus Strießnig <[email protected]>

* unsubscribe feature flags

Signed-off-by: Klaus Strießnig <[email protected]>
@johannes-b johannes-b added this to the 0.12.0 (Bridge) milestone Dec 10, 2021
@johannes-b johannes-b mentioned this issue Dec 10, 2021
Closed
@ekmixon ekmixon mentioned this issue Dec 28, 2023
Open
@ekmixon ekmixon mentioned this issue Jan 5, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Kirdock Kirdock

Labels
bridge.2.0 Bridge Version 2 kep:60
Projects
None yet
Milestone
0.12.0 (Bridge)
Development

Successfully merging a pull request may close this issue.

feat(bridge): Feature flags for bridge server (#6073) keptn/keptn
3 participants
@johannes-b @thisthat @Kirdock