Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore: Introduce needed methods before deprecating kubernetes-utils #477

Merged
merged 14 commits into from
Jun 24, 2022
Merged

chore: Introduce needed methods before deprecating kubernetes-utils #477

merged 14 commits into from
Jun 24, 2022

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

This PR

  • adds functions needed after deprecation of kubernetes-utils

github-actions[bot]
github-actions bot reviewed Jun 20, 2022
View reviewed changes
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
@odubajDT odubajDT changed the title first version chore: Introduce needed methods before deprecating kubernetes-utils Jun 20, 2022
RealAnna
RealAnna reviewed Jun 20, 2022
View reviewed changes
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/common.go Outdated Show resolved Hide resolved
@odubajDT
move to correct folder
e3a3061 
Signed-off-by: odubajDT <[email protected]>
github-actions[bot]
github-actions bot reviewed Jun 20, 2022
View reviewed changes
pkg/common/kubeutils/kubeutils.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/kubeutils.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/kubeutils.go Outdated Show resolved Hide resolved
@odubajDT
fix
7e164df 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
restructuring
920100f 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
go mod tidy
d560195 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as draft June 22, 2022 08:49
@odubajDT
restructure
15d6d22 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
refactor code
8a704ae 
Signed-off-by: odubajDT <[email protected]>
github-actions[bot]
github-actions bot reviewed Jun 22, 2022
View reviewed changes
pkg/common/kubeutils/apitoken_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/apitoken_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/apitoken_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/apitoken_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/endpoint_provider.go Show resolved Hide resolved
pkg/common/kubeutils/endpoint_provider.go Show resolved Hide resolved
pkg/common/kubeutils/kubeclientset_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/namespace_manager.go Show resolved Hide resolved
pkg/common/kubeutils/namespace_manager.go Outdated Show resolved Hide resolved
@odubajDT
remove unneeded methods
bc8f6b7 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
first version of tests
dc947f6 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
covered by tests
b4baadc 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review June 23, 2022 06:30
@odubajDT
missing comments
edc3ce2 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
polish
6e8c2c2 
Signed-off-by: odubajDT <[email protected]>
github-actions[bot]
github-actions bot reviewed Jun 23, 2022
View reviewed changes
pkg/common/kubeutils/apitoken_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/endpoint_provider.go Outdated Show resolved Hide resolved
pkg/common/kubeutils/namespace_manager.go Outdated Show resolved Hide resolved
@odubajDT
fix
bf6c09d 
Signed-off-by: odubajDT <[email protected]>
RealAnna
RealAnna previously approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odubajDT
pr review
046c549 
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 4d49101 into master Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@warber warber warber approved these changes

@RealAnna RealAnna RealAnna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odubajDT @warber @RealAnna