Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release action #9

Closed
wants to merge 1 commit into from
Closed

fix: release action #9

wants to merge 1 commit into from

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Nov 2, 2023

Signed-off-by: Giovanni Liva <[email protected]>
@@ -64,7 +64,7 @@ jobs:

- name: Move old latest release documentation folder
if: ${{ steps.folder.outputs.migrate }}
run: mv -fv "${{ inputs.page_dir }}${{ inputs.docs_dir }}/content/en/docs/." "${{ inputs.page_dir }}${{ inputs.docs_dir }}/content/en/${{ steps.folder.outputs.migrate }}"
run: mv -fv "${{ inputs.page_dir }}${{ inputs.docs_dir }}/content/en/docs" "${{ inputs.page_dir }}${{ inputs.docs_dir }}/content/en/${{ steps.folder.outputs.migrate }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with cp -R here, as there is a potential risk that the device can be busy when moving. Afterwards we can use rm -rf for the cleanup as this removes the folder also when it's opened (device is busy)

@thisthat
Copy link
Member Author

thisthat commented Nov 6, 2023

superseded by keptn/lifecycle-toolkit#2420

@thisthat thisthat closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants