Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve integration test pipeline with a gitea provisioner #149

Merged
merged 6 commits into from
Jul 4, 2022
Merged

feat: Improve integration test pipeline with a gitea provisioner #149

merged 6 commits into from
Jul 4, 2022

Conversation

christian-kreuzberger-dtx
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx commented Jun 29, 2022 •
edited
Loading

This PR levels up our integration test pipeline for the service template.

  • We now include the brand new gitea provisioner
  • We also include the brand new keptn-install-action
  • I added Kubernetes log output and the debug archive, because it's awesome for troubleshooting
  • I updated the Keptn versions we test against
  • Update helm chart values hostname pattern to allow host(:port) combinations
  • Removed distributor version from skaffold.yaml as it's redundant with what we have in helm chart values.yaml

Integration Test Run: https://github.com/keptn-sandbox/keptn-service-template-go/actions/runs/2582718669

@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited
Loading

Unit Test Results

7 tests   5 ✔️  5s ⏱️
2 suites  2 💤
1 files    0 ❌

Results for commit 2c96294.

♻️ This comment has been updated with latest results.

@christian-kreuzberger-dtx
Improve readme
74b73e4 
Signed-off-by: Christian Kreuzberger <[email protected]>
@christian-kreuzberger-dtx
Fix missing namespace
9666fcb 
Signed-off-by: Christian Kreuzberger <[email protected]>
pchila
pchila reviewed Jun 29, 2022
View reviewed changes
.github/workflows/integration_tests.yml Show resolved Hide resolved
.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
@christian-kreuzberger-dtx
review changes
2c96294 
Signed-off-by: Christian Kreuzberger <[email protected]>
@christian-kreuzberger-dtx
Copy link
Contributor Author

@pchila I've included your suggestions, thanks!

@github-actions
Copy link

The following Docker Images have been built:
ghcr.io/keptn-sandbox/keptn-service-template-go:0.14.1-dev-PR-149,ghcr.io/keptn-sandbox/keptn-service-template-go:0.14.1-dev-PR-149.202206301050

Raffy23
Raffy23 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@Raffy23 Raffy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the patch/up-integration-tests branch July 4, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchila pchila pchila left review comments

@Raffy23 Raffy23 Raffy23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christian-kreuzberger-dtx @Raffy23 @pchila