Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decouple integration tests from name of service #148

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

christian-kreuzberger-dtx
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx commented Jun 27, 2022

@Raffy23 and I noticed that we use the name "keptn-service-template-go" a couple of times in integration test.

Unfortunately, the init-repo workflow is not allowed to replace those occurances, therefore we ran into problems when using this repo.

I removed all occurances, and did some smaller changes to the workflow, now it should work.

Integration test run: https://github.com/keptn-sandbox/keptn-service-template-go/actions/runs/2567817178

@github-actions
Copy link

github-actions bot commented Jun 27, 2022

Unit Test Results

7 tests   5 ✔️  5s ⏱️
2 suites  2 💤
1 files    0

Results for commit 57bf6f3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

The following Docker Images have been built:
ghcr.io/keptn-sandbox/keptn-service-template-go:0.14.1-dev-PR-148,ghcr.io/keptn-sandbox/keptn-service-template-go:0.14.1-dev-PR-148.202206270825

Copy link
Contributor

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the patch/fix-integration-tests branch June 27, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants