This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
fix: error messages are no longer attached to indicator from event if dashboard processing fails #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
in case of querying a dashboard would fail Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
Signed-off-by: Joerg Poecher <[email protected]>
j-poecher
requested review from
agrimmer,
arthurpitman,
heckelmann,
jskelin and
Kavindu-Dodan
as code owners
j-poecher
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -25,6 +25,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ProblemOpenSLI = "problem_open" | |||
| const NoMetricIndicator = "no metric" | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported const NoMetricIndicator should have comment or be unexported
| return e.err | ||
| } | ||
|
|
||
| type UploadFileError struct { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported type UploadFileError should have comment or be unexported
Signed-off-by: Joerg Poecher <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
The following Docker Images have been built: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #538