Adds a check for running in test mode without db connection #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock their outputs.
…loy server delay is necessary to capture the noise fields of response accurately
…indone mocked method refactors kmongo code to improve maintainence #63
…puts of external http calls
…od of ReadCloser to decode gcp response in UnmarshalBinary method, the b byte array contents are copied to a temp byte array to prevent alteration in the given parameter b byte array
|
@re-Tick As discussed, please ensure to correctly deserialize errors so that they match the exact declared in the sql/driver packages. |
…stead of KError.Err This is done because sql package compares errors by using == or errors.Is so, errors should be same instances.
re-Tick
added a commit
that referenced
this pull request
Aug 18, 2022
* feat(mongo): Adds Distinct, CountDocuments and Aggregate methods to mock their outputs. * fix(keploy): adds a delay in between capture and denoise calls to keploy server delay is necessary to capture the noise fields of response accurately * fix(kmongo): adds a check for nil pointer to prevent crash in find, findone mocked method refactors kmongo code to improve maintainence #63 * feat(kmux): adds a middleware function for gorilla/mux multiplexer #66 * fix(khttpClient): adds an interceptor for http client to mock the outputs of external http calls * docs: fixed typo in sql driver's example * fix(khttpClient): register types to gob and fixes UnmarshalBinay method of ReadCloser to decode gcp response in UnmarshalBinary method, the b byte array contents are copied to a temp byte array to prevent alteration in the given parameter b byte array * docs(gcp): adds an example in readme for a gcp compute * fix(ksql): run the mocked outputs of sql queries when database is down #70 * fix(ksql): keploy sql driver methods returns the sql/driver errors instead of KError.Err This is done because sql package compares errors by using == or errors.Is so, errors should be same instances. Co-authored-by: Ritik Jain <[email protected]> Signed-off-by: re-Tick <[email protected]>
re-Tick
added a commit
that referenced
this pull request
Aug 25, 2022
* feat(mongo): Adds Distinct, CountDocuments and Aggregate methods to mock their outputs. * fix(keploy): adds a delay in between capture and denoise calls to keploy server delay is necessary to capture the noise fields of response accurately * fix(kmongo): adds a check for nil pointer to prevent crash in find, findone mocked method refactors kmongo code to improve maintainence #63 * feat(kmux): adds a middleware function for gorilla/mux multiplexer #66 * fix(khttpClient): adds an interceptor for http client to mock the outputs of external http calls * docs: fixed typo in sql driver's example * fix(khttpClient): register types to gob and fixes UnmarshalBinay method of ReadCloser to decode gcp response in UnmarshalBinary method, the b byte array contents are copied to a temp byte array to prevent alteration in the given parameter b byte array * docs(gcp): adds an example in readme for a gcp compute * fix(ksql): run the mocked outputs of sql queries when database is down #70 * fix(ksql): keploy sql driver methods returns the sql/driver errors instead of KError.Err This is done because sql package compares errors by using == or errors.Is so, errors should be same instances. Co-authored-by: Ritik Jain <[email protected]> Signed-off-by: re-Tick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.