Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug (keploy#834) #198

Merged
merged 3 commits into from
Sep 16, 2023
Merged

fix: bug (keploy#834) #198

merged 3 commits into from
Sep 16, 2023

Conversation

AkashKumar7902
Copy link
Contributor

@AkashKumar7902 AkashKumar7902 commented Sep 15, 2023

Pull Request Template

Description

dropdownItemsAfter is used to add additional dropdown items. So earlier there were 2 version items in the dropdown plus an additional item added through dropdownItemsAfter with no label.

Fixes # (keploy/keploy#834)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

@AkashKumar7902
Copy link
Contributor Author

AkashKumar7902 commented Sep 15, 2023

Hi,
I am sorry for committing the CI fixes in the same branch. I realized it after committing my changes :(
If you want I will split this PR into two and close this one.

Akash Kumar

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nehagup nehagup closed this Sep 16, 2023
@nehagup nehagup reopened this Sep 16, 2023
@nehagup nehagup merged commit e0f117e into keploy:main Sep 16, 2023
6 of 7 checks passed
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* fix: bug (keploy#834)

Signed-off-by: Akash Kumar <[email protected]>

* fix: deploy PR previews error

Signed-off-by: Akash Kumar <[email protected]>

* ci: add install dependencies step

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
swatichauhan814 pushed a commit to swatichauhan814/docs that referenced this pull request Oct 7, 2023
* fix: bug (keploy#834)

Signed-off-by: Akash Kumar <[email protected]>

* fix: deploy PR previews error

Signed-off-by: Akash Kumar <[email protected]>

* ci: add install dependencies step

Signed-off-by: Akash Kumar <[email protected]>

---------

Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: schauhan2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants