Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Notification systems with new UI panel and helpers to generate messages #333

Merged
merged 12 commits into from
Jan 18, 2019
Merged

[Feature] Notification systems with new UI panel and helpers to generate messages #333

merged 12 commits into from
Jan 18, 2019

Conversation

macrigiuseppe
Copy link
Collaborator

@macrigiuseppe macrigiuseppe commented Jan 16, 2019 •
edited
Loading

This pull request is a follow up to RFC #307 .

New features:

  • Ability to create notifications using helpers
    • createNotification
    • successNotfication
    • errorNotfication
  • React components can now dispatch two new actions:
    • addNotification({message: 'this is a message', type: 'error', topic: 'global, ...})
    • removeNotification(notificationId)
  • Two new React components
    • NotificationPanel: container and list of notifications. This component receives the uiState with all notifications and it will only display notifications with the topic set to 'global'
    • NotificationPanelItem: component to display notification message. The new item supports markdown messages.

Both components are injected using dependency injection hence they are also replaceable by using custom components

kepler-notification

@macrigiuseppe macrigiuseppe self-assigned this Jan 16, 2019
@macrigiuseppe macrigiuseppe changed the title New notification system (https://github.com/uber/kepler.gl/issues/307) New notification system Jan 16, 2019
heshan0131
heshan0131 reviewed Jan 17, 2019
View reviewed changes
examples/demo-app/src/app.js Outdated Show resolved Hide resolved
src/components/notification-panel/notification-item.js Show resolved Hide resolved
src/reducers/ui-state-updaters.js Outdated Show resolved Hide resolved
src/components/kepler-gl.js Outdated Show resolved Hide resolved
src/components/kepler-gl.js Outdated Show resolved Hide resolved
@macrigiuseppe macrigiuseppe changed the title New notification system [Feature] Notification systems with new UI panel and helpers to generate messages Jan 18, 2019
@macrigiuseppe macrigiuseppe merged commit 3096353 into master Jan 18, 2019
@macrigiuseppe macrigiuseppe deleted the 307_notifications branch January 18, 2019 22:04
macrigiuseppe added a commit that referenced this pull request Jan 19, 2019
@macrigiuseppe
[Feature] Notification systems with new UI panel and helpers to gener…
bc09c03 
…ate messages (#333)

    * Added notification utils/reducers with tests

    * Created first version of notification container

    * implemented logic to show/hide notifications

    * Able to visualize different types of notifications

    * Added first design for global notifications

    * Able to collpase and expand notifications

    * Showing only global notifications

    * Added markdown support

    * Added tests for notification panel and item

    * Removed uber npm repo references
macrigiuseppe added a commit that referenced this pull request Jan 19, 2019
@macrigiuseppe
[Feature] Notification systems with new UI panel and helpers to gener…
6e8e2f4 
…ate messages (#333)

    * Added notification utils/reducers with tests

    * Created first version of notification container

    * implemented logic to show/hide notifications

    * Able to visualize different types of notifications

    * Added first design for global notifications

    * Able to collpase and expand notifications

    * Showing only global notifications

    * Added markdown support

    * Added tests for notification panel and item

    * Removed uber npm repo references
@geostarters geostarters mentioned this pull request Jan 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieMartell CharlieMartell CharlieMartell left review comments

@heshan0131 heshan0131 heshan0131 approved these changes

Assignees

@macrigiuseppe macrigiuseppe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macrigiuseppe @heshan0131 @CharlieMartell