Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Vector Tile layer fixes #2899

Merged
merged 16 commits into from
Jan 10, 2025
Merged

[feat] Vector Tile layer fixes #2899

merged 16 commits into from
Jan 10, 2025

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Jan 7, 2025 •
edited
Loading

  • show Vector Tile layer tab
  • changes to radius controls
  • fix highlighted filled polygons
  • hide show data table icon
  • display loading spinner while we are loading metadata
  • display errors metadata loading failed
  • fix for custom ordinal crash when all colors are deleted
  • collect dataset attributions from metadata and show in the lower right corner
  • refetch tile dataset metadata createNewDataEntry

@igorDykhta
enable vector tile layer
56d5fad 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
minor ts fixes
424b840 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta requested a review from ilyabo January 7, 2025 15:49
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit d6e7a44
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/67819742d0a26e0008fe8436
😎 Deploy Preview https://deploy-preview-2899--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igorDykhta
ts
16a27d1 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
prevent crash in custom ordinal
d7f535b 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
more usable radius control
9832dab 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
fix fill highlighting
f136bb5 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
show data table - disable for vector tiles
54ad0d2 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
remove decodeURIComponent before PMTilesSource
ccdf0b5 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
restore loading spinner for vector tiles; minor refactoring
747d1b1 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
fix tests
0926e24 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
fix metadata loading error reporting
c374c26 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
collect dataset attributions from metadata
dc68043 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
temp fix to get mvt attribution; show dataset attribution
1e785ef 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
fix jest tests
645fbc5 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
refetch tileset metadata once dataset is added to the state; refactor…
33e4ed9 
…ing;

Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta
temp disable vector tile layer
d6e7a44 
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta marked this pull request as ready for review January 10, 2025 21:58
@igorDykhta igorDykhta merged commit 2753321 into master Jan 10, 2025
12 checks passed
@igorDykhta igorDykhta deleted the igr/vector-tiles-cont branch January 10, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyabo ilyabo ilyabo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorDykhta @ilyabo