Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] experimental support for ARROW:extension:point #2674

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Oct 7, 2024

  • adds support for ARROW:extension:name EXTENSION_NAME.POINT position columns in Point, Line, Arc, Text layers.
  • can pick geoarrow point column as source for Heatmap layer.
  • interleaved xy geoarrow point vector is passed directly as a position data attribute for rendering.
  • separate lon / lat columns are converted to geoarrow point vectors (only when source file is an .arrow file).
  • this PR doesn't affect existing loading and support of non-geo columns.

Known issues:

  • text layer supplied with ARROW:extension:point column can only render string arrow columns (no values offsets).

  • figure out how to store an Arrow table in Arrow Data containers, and to update it properly with progressive loading.

  • check whether changes in esbuild.config.mjs are required after loaders bump

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for keplergl2 failed. Why did it fail? →

Name Link
🔨 Latest commit aa68891
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/67041322e0136800082a40ab

@igorDykhta igorDykhta changed the base branch from master to igr/deckgl-arrow-layers-module October 10, 2024 16:14
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta deleted the branch keplergl:igr/deckgl-arrow-layers-module October 22, 2024 18:10
@igorDykhta igorDykhta closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant