Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix for starting demo-app #2594

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

igorDykhta
Copy link
Collaborator

Fir for starting demo-app.

At the moment running yarn start produces the following error:

ERROR in ./node_modules/@loaders.gl/core/node_modules/@probe.gl/log/dist/utils/hi-res-timestamp.js 7:27
Module parse failed: Unexpected token (7:27)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     let timestamp;
|     if (isBrowser() && window.performance) {
>         timestamp = window?.performance?.now?.();
|     }
|     else if ('hrtime' in process) {

Possibly related to #2593

Signed-off-by: Ihor Dykhta <[email protected]>
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 73d90ed
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66a22f9667850e0008c54dbc
😎 Deploy Preview https://deploy-preview-2594--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas

  • why is this suddenly needed? Is the build of the demo app not tested by CI?
  • why isn't the CJS distribution in probel.gl / loaders.gl 4.x being picked up, is it some configuration issue?
  • This will be a problem for all visgl libraries once we upgrade to v9 so kepler will be recompiling all of vis.gl at that point, even though CJS distributions are included.

@echo292
Copy link

echo292 commented Jul 25, 2024

@ibgreen Kepler.gl 3.0 release doesn't run as per current documentation. Do you have a list of steps to run the demo we can publish in the documentation?

Regards,

E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants