Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: video export with hubble.gl WIP #2482

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

igorDykhta
Copy link
Collaborator

TBD WIP

@chrisgervang
Copy link
Collaborator

chrisgervang commented Feb 7, 2024

Tested this PR with the world flights demo. It works minimally, I'll describe what works and doesn't work (apologies if these are already known issues).

Works:

  • Dark, Light, Muted Light, Muted Night, Satellite base maps.
  • Camera animation and video export (though, no deck layers render so its just a basemap)

Dark basemap works. World flight layers visible in the background, but not in the exporter:
Screen Shot 2024-02-07 at 9 47 18 AM

Output:
kepler.gl.webm

Non-functional:

  • The custom "Kepler.GL Flight Map" works in the main map, but 404s in the video exporter.
  • Deck layers do not render
  • When the basemap isn't loading correctly and the modal is closed, the app crashes (uncaught error trying to reference a _listeners variable)

When using the "Kepler.GL Flight Map" basemap:

Screen Shot 2024-02-07 at 9 42 36 AM
Screen Shot 2024-02-07 at 9 42 44 AM

Crash when closing the modal when it failed to load a basemap:
Screen Shot 2024-02-07 at 9 43 08 AM
Screen Shot 2024-02-07 at 9 43 14 AM

@igorDykhta
Copy link
Collaborator Author

Tested this PR with the world flights demo. It works minimally, I'll describe what works and doesn't work (apologies if these are already known issues).

Yes, it's in draft/WIP state. This was the original integration which is obviously out of date with the current kepler/deck versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants