Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Layer column config: sometimes a suggested field pair will hard crash #2351

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

igorDykhta
Copy link
Collaborator

  • Fixes a hard crash that can occur when the user selects a suggested field pair for a layer geometry column that would lead to an undefined column in the base layer assignColumnPairs method.

  • The solution adds an additional short-circuit in the base layer method assignColumnPairs if that is the case, but more importantly also first prevents the UI from providing invalid suggested field pair choices that would lead to this condition.

  • Adds a couple of test cases to help document to devs what the underlying findPointFieldPairs data method is intended to do.

@igorDykhta igorDykhta merged commit 032ad76 into master Oct 2, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the igr/ups-fix-sugg-pair-crash branch October 2, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants